Removed Trigger double Body deletion #6365
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MushAsterion
added
area: physics
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Closed? |
|
Yes sorry, it seems the change is not fixing the original issue and I'm definitely blind as the first only remove the body and don't destroy it so this one is fine. Sorry for the early PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6364
Trigger#destroy was calling
destroyBodywhile already being called earlier fromthis.disablewithin the same function leading to Ammo.js trying to destroy an empty referenceI confirm I have read the contributing guidelines and signed the Contributor License Agreement.