Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webpack ignore #6359

Merged
merged 1 commit into from
May 14, 2024
Merged

Add webpack ignore #6359

merged 1 commit into from
May 14, 2024

Conversation

marklundin
Copy link
Member

Adds /* webpackIgnore: true */ to the bundler plugin to suppress webpack warnings with dynamic expressions.

See https://forum.playcanvas.com/t/webpack-issue-with-playcanvas-engine-1-70-2/35856/2

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
engine ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 8:17am

Copy link
Contributor

@mvaligursky mvaligursky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but lets get @kpal81xd to double check this

@kpal81xd
Copy link
Contributor

@marklundin looks good have you tested?

@marklundin
Copy link
Member Author

yeah its fine

@marklundin marklundin merged commit 4afdded into main May 14, 2024
9 checks passed
@marklundin marklundin deleted the webpack-supress branch May 14, 2024 09:51
mvaligursky pushed a commit that referenced this pull request May 14, 2024
slimbuck pushed a commit to slimbuck/engine that referenced this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants