Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support arduino for nucleo_h753zi #748

Merged

Conversation

asukiaaa
Copy link
Contributor

nucleo_h753zi is supported from arduino core stm32 2.7.0 so I want you to support it.
stm32duino/Arduino_Core_STM32@0fb3eff

@maxgerhardt
Copy link
Contributor

@valeros valeros merged commit 53e7766 into platformio:develop Jul 1, 2024
@valeros
Copy link
Member

valeros commented Jul 1, 2024

Many thanks for the PR, merged.

@asukiaaa asukiaaa deleted the feature/support-arduino-for-nucleo-h753zi branch July 1, 2024 13:48
@asukiaaa
Copy link
Contributor Author

asukiaaa commented Jul 1, 2024

Thank you for merging but do I need someone's request to be checked by you?

@valeros
Copy link
Member

valeros commented Jul 1, 2024

Thank you for merging but do I need someone's request to be checked by you?

No, we usually review Arduino-related changes when integrating a new version of the Arduino core. Your PR were added just after we released support for core v2.7, so it took a bit of time. Coincidentally, @maxgerhardt pinged just in time when a new v2.8.0 was released.

@asukiaaa
Copy link
Contributor Author

asukiaaa commented Jul 1, 2024

Thank you for answering but why other PR that mention about board supported from 2.7 was merged in few days?
#773

@valeros
Copy link
Member

valeros commented Jul 2, 2024

As I said, usually the PR are reviewed in synch with the Arduino core update, if a similar PR was merged is rather an exception that a rule.

@asukiaaa
Copy link
Contributor Author

asukiaaa commented Jul 2, 2024

I see that the PR was exception for the rule.
I want some tag to know that PR is not ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants