Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement upload_resetmethod option for stlink upload #603

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

saierd
Copy link

@saierd saierd commented Mar 6, 2022

The ST-Link upload fails with some clones of the ST-Link device, because they do not support the reset pin properly. This results in the error Error: timed out while waiting for target halted during upload. See e.g. #168.

The issue can be solved by changing OpenOCD's reset_config option. People in various threads do this by modifying the board configuration files on their system, which is obviously not a portable solution.

This commit allows to specify an upload_resetmethod option in platformio.ini, which is forwarded as the reset_config option to OpenOCD. The option with the same name already exists for the Espressif 8266 platform and does something similar there. It is documented here.

@saierd
Copy link
Author

saierd commented Jan 22, 2023

@ivankravets @valeros Sorry to ping you, but there has been no feedback on this (as well as other pull requests in this repository) for a long time.

Is this change considered for getting merged? Is there anything I should change in order to get it merged?

@angelnu
Copy link

angelnu commented Jan 20, 2024

I would also apprecitate this being merged as it is required to upload with the clone ST-Link devices.

Using @saierd PR branch worked for me:

[env:distance_v1]
        platform = https://github.com/saierd/platform-ststm32.git#upload_resetmethod
        debug_tool = stlink
        upload_protocol = stlink
        upload_resetmethod = none separate

As it only adds support for an option I would not expect any regresion for anyone else.

@saierd - could you please update you branch with the latest commits - it is behind the upstream so it is missing some updates. Thanks!

@saierd
Copy link
Author

saierd commented Jan 21, 2024

@angelnu I have rebased my branch.

I would also still like to get this merged. Unfortunately I never got any feedback on it. It seems like most of the PRs in this repository are not looked at.

@angelnu
Copy link

angelnu commented Jan 21, 2024

Thanks @saierd . You might want to, if not done already, try posting in the platformio forum. The PRs usually tet discussed there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants