API for emailLogEntry #10455
Merged
API for emailLogEntry #10455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taslangraham
force-pushed
the
i10412-main
branch
from
34ddfd9
to
46d8f15
Compare
taslangraham
force-pushed
the
i10412-main
branch
from
500b13e
to
cbb0f53
Compare
ewhanson
requested changes
Sep 27, 2024
api/v1/emails/PKPEmailController.php
Outdated
|
|
||
| foreach ($illuminateRequest->query->keys() as $queryParam) { | ||
| if (!in_array($queryParam, $allowedQueryParams)) { | ||
| return response()->json([ |
There was a problem hiding this comment.
I understand where this is coming from but I don't think we should respond with an error of an invalid query parameter is included (this is the case elsewhere as well). For example, I'm using an XDEBUG_SESSION query parameter to debug API requests and this will fail because of that. I think it's okay to have the correct query parameters documented and silently ignore others.
There was a problem hiding this comment.
Noted. I'll update accordingly
api/v1/emails/PKPEmailController.php
Outdated
| protected function getMany(Request $illuminateRequest): JsonResponse | ||
| { | ||
| $allowedQueryParams = ['submissionId', 'eventType']; | ||
| $authorEmailLogEventTypes = [ SubmissionEmailLogEventType::EDITOR_NOTIFY_AUTHOR, SubmissionEmailLogEventType::COPYEDIT_NOTIFY_AUTHOR,SubmissionEmailLogEventType::PROOFREAD_NOTIFY_AUTHOR]; |
There was a problem hiding this comment.
Some spacing issues in the array.
taslangraham
force-pushed
the
i10412-main
branch
3 times, most recently
from
69914ed
to
e9a1eaf
Compare
taslangraham
force-pushed
the
i10412-main
branch
from
e9a1eaf
to
770b9a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #10412