#10189 Convert Queries to an Eloquent Model #10384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaitlinnewson
force-pushed
the
10189-main
branch
11 times, most recently
from
45a02ff
to
7ae8d92
Compare
kaitlinnewson
force-pushed
the
10189-main
branch
6 times, most recently
from
27a8cc4
to
411193d
Compare
taslangraham
requested changes
Sep 17, 2024
There was a problem hiding this comment.
Mostly looks good @kaitlinnewson. I just had a few questions and suggestions
classes/notification/managerDelegate/PKPEditingProductionStatusNotificationManager.php
Outdated
Show resolved
Hide resolved
Hafsa-Naeem
reviewed
Sep 18, 2024
|
@kaitlinnewson the PR looks good to me. 👍 I've added a few comments and suggestions. |
There was a problem hiding this comment.
@kaitlinnewson I have added few comments, mostly suggestions/questions . Take a look and feel free to address those if you think it make sense . Otherwise this look good to me .
classes/notification/managerDelegate/PKPEditingProductionStatusNotificationManager.php
Outdated
Show resolved
Hide resolved
kaitlinnewson
force-pushed
the
10189-main
branch
from
0fa4bc6
to
70a3fa1
Compare
asmecher
reviewed
Sep 23, 2024
| @@ -58,14 +54,14 @@ public function getNotificationMessage(PKPRequest $request, Notification $notifi | |||
| 'noteTitle' => Str::limit($headNote->title, 200), | |||
| ]); | |||
| case Notification::NOTIFICATION_TYPE_QUERY_ACTIVITY: | |||
| $latestNote = Note::withAssoc(PKPApplication::ASSOC_TYPE_QUERY, $query->getAssocId()) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.