Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+windows #823

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

+windows #823

wants to merge 1 commit into from

Conversation

mxcl
Copy link
Member

@mxcl mxcl commented Oct 20, 2023

No description provided.

@coveralls
Copy link

coveralls commented Oct 20, 2023

Pull Request Test Coverage Report for Build 6613581632

  • 15 of 27 (55.56%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 96.138%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/modes/internal.activate.ts 9 13 69.23%
src/modes/run.ts 2 10 20.0%
Totals Coverage Status
Change from base Build 6612745233: -0.7%
Covered Lines: 1396
Relevant Lines: 1436

💛 - Coveralls

@felipecrs
Copy link
Contributor

A suggestion in case you have not thought about it yet:

Perhaps using something like https://github.com/dsherret/dax in brewkit can help minimize the changes needed in pantry regarding the build scripts (assuming you are not going to use MSYS2 or Cygwin to provide native Bash on Windows).

@mxcl mxcl force-pushed the main branch 2 times, most recently from 9038067 to 342373c Compare April 23, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants