Rebuild dummy-app in Rails 7 #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed this PR has removed some of the tests that were in the /spec/dummy-app/spec directory. I've put in a PR to move the specs out of the dummy app which you may want to have merged before you merge this one |
quorauk
suggested changes
Aug 25, 2023
There was a problem hiding this comment.
The only important thing I noticed was that logging out doesn't work. I think this is a rails 7 change.
in spec/dummy-app/app/views/authenticated/index.html.erb
You will need to do the following to make it work
-<%= link_to 'Log out', destroy_user_session_path, method: :delete %>
+<%= button_to 'Log out', destroy_user_session_path, method: :delete %>
In Rails 7, link_to defaults to :get method when JS is disabled That is why we are using button_to, which can be assigned :delete method
It was probably created when generating a lot of Rails 7 files/folders
JonathanAndrews
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Ticket
https://github.com/orgs/pixielabs/projects/4?pane=issue&itemId=31864306
Before submitting have you:
After submitting remember to: