Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track system language #109

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Track system language #109

wants to merge 2 commits into from

Conversation

Patrycja-Nowak
Copy link
Contributor

Changes

  • Add tracking system language to the algorithm calculating the match score
  • Change score that needs to be achieved for successful login (because we introduced another aspect)
  • Add tests

Ticket

https://github.com/orgs/pixielabs/projects/4/views/1?pane=issue&itemId=36262820

Before submitting have you:

  • Included a link to any relevant ticket
  • Included links to any github issues
  • Prefix the title with the PR type (Feature, Bugfix, Documentation, Chore)

After submitting remember to:

  • Mark the ticket as ready for review
  • Include the PR on the ticket
  • Assign a single reviewer

JonathanAndrews
JonathanAndrews requested changes Jan 26, 2024
View reviewed changes
Copy link
Collaborator

@JonathanAndrews JonathanAndrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @PatMiekina!
I've left a couple of change requests below.

app/controllers/devise_recognisable/sessions_controller.rb Outdated Show resolved Hide resolved
spec/dummy-app/spec/features/sign_in_spec.rb Outdated Show resolved Hide resolved
spec/dummy-app/spec/features/sign_in_spec.rb Outdated Show resolved Hide resolved
spec/dummy-app/spec/features/sign_in_spec.rb Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonathanAndrews JonathanAndrews Awaiting requested review from JonathanAndrews

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Patrycja-Nowak @JonathanAndrews