Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numpy 2.0.0 update and removing deprecated scipy modules #3562

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

hechth
Copy link

@hechth hechth commented Nov 7, 2024

This PR is an initial attempt at porting the project to numpy 2.0.0 - so far running the tests manually after installing all dependencies seemed fine. I removed the deprecated scipy sparse functions and replaced them with the normal operator versions.

@hechth
Copy link
Author

hechth commented Nov 7, 2024

@mpenkov @gojomo @piskvorky could you run the CI on this and see if this works fine?

@piskvorky
Copy link
Owner

Done :)

@hechth
Copy link
Author

hechth commented Nov 7, 2024

@piskvorky argh the linter :D

@hechth
Copy link
Author

hechth commented Nov 7, 2024

@piskvorky could you re-trigger? Or is there a way how I can execute test in a way that is comparable to the CI?

@YoungMind1 YoungMind1 mentioned this pull request Nov 8, 2024
@yoannspace
Copy link

yoannspace commented Nov 8, 2024

@hechth @YoungMind1 Thanks for looking into this!
Can I also suggest to have a look at scipy >=1.14 (https://github.com/piskvorky/gensim/pull/3563/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7R336)?
Since you already removed the scipy spartools in this PR (and if lucky there is nothing else to change)...

Edit: Sorry... Realized scipy 1.14 requires python 3.10 too late. Forget it, maybe in a later version.

@julianpollmann
Copy link

Upgrading numpy will fail tests, since saving in word2vec format will save keyvectors as strings of numpy datatypes instead of strings of floats.

@julianpollmann
Copy link

@hechth I opened a PR in your fork for fixing tests for numpy 2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants