Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Node 18 support #258

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add Node 18 support #258

wants to merge 4 commits into from

Conversation

brunoasr
Copy link
Contributor

Summary

Orion currently uses React 16, that depends on Webpack 4, not compliant with Node 18. This workaround allows project to be built under Node 18.

Test Plan

./build_ui.sh
npm WARN using --force Recommended protections disabled.
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: [email protected]
npm WARN Found: [email protected]
npm WARN node_modules/react-dnd
npm WARN   react-dnd@"^11.1.3" from [email protected]
npm WARN   node_modules/mui-datatables
npm WARN     mui-datatables@"^3.4.1" from the root project
npm WARN   1 more (react-sortable-tree)
npm WARN
npm WARN Could not resolve dependency:
npm WARN peer react-dnd@"^7.3.0" from [email protected]
npm WARN node_modules/frontend-collective-react-dnd-scrollzone
npm WARN   frontend-collective-react-dnd-scrollzone@"^1.0.2" from [email protected]
npm WARN   node_modules/react-sortable-tree
npm WARN
npm WARN Conflicting peer dependency: [email protected]
npm WARN node_modules/react-dnd
npm WARN   peer react-dnd@"^7.3.0" from [email protected]
npm WARN   node_modules/frontend-collective-react-dnd-scrollzone
npm WARN     frontend-collective-react-dnd-scrollzone@"^1.0.2" from [email protected]
npm WARN     node_modules/react-sortable-tree
npm WARN deprecated @babel/[email protected]: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-unicode-property-regex instead.
npm WARN deprecated @babel/[email protected]: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-optional-catch-binding instead.
npm WARN deprecated @babel/[email protected]: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-object-rest-spread instead.
npm WARN deprecated @babel/[email protected]: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-json-strings instead.
npm WARN deprecated @babel/[email protected]: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-dynamic-import instead.
npm WARN deprecated @babel/[email protected]: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-async-generator-functions instead.
npm WARN deprecated @hapi/[email protected]: Moved to 'npm install @sideway/address'
npm WARN deprecated @hapi/[email protected]: This version has been deprecated and is no longer supported or maintained
npm WARN deprecated @hapi/[email protected]: This version has been deprecated and is no longer supported or maintained
npm WARN deprecated [email protected]: It is not compatible with newer versions of GA starting with v4, as long as you are using GAv3 it should be ok, but the package is not longer being maintained
npm WARN deprecated @hapi/[email protected]: This version has been deprecated and is no longer supported or maintained
npm WARN deprecated @hapi/[email protected]: Switch to 'npm install joi'
npm WARN deprecated [email protected]: This module is no longer supported.
npm WARN deprecated [email protected]: Modern JS already guarantees Array#sort() is a stable sort, so this library is deprecated. See the compatibility table on MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#browser_compatibility
npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated [email protected]: See https://github.com/lydell/source-map-url#deprecated
npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated [email protected]: See https://github.com/lydell/source-map-resolve#deprecated
npm WARN deprecated [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated [email protected]: this library is no longer supported
npm WARN deprecated [email protected]: flatten is deprecated in favor of utility frameworks such as lodash.
npm WARN deprecated [email protected]: request-promise-native has been deprecated because it extends the now deprecated request package, see https://github.com/request/request/issues/3142
npm WARN deprecated [email protected]: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated [email protected]: use String.prototype.padStart()
npm WARN deprecated [email protected]: Use your platform's native DOMException instead
npm WARN deprecated [email protected]: Use your platform's native atob() and btoa() methods instead
npm WARN deprecated [email protected]: Use your platform's native performance.now() and performance.timeOrigin.
npm WARN deprecated [email protected]: some dependency vulnerabilities fixed, support for node < 10 dropped, and newer ECMAScript syntax/features added
npm WARN deprecated @babel/[email protected]: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-optional-chaining instead.
npm WARN deprecated @babel/[email protected]: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-nullish-coalescing-operator instead.
npm WARN deprecated @babel/[email protected]: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-numeric-separator instead.
npm WARN deprecated @babel/[email protected]: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-class-properties instead.
npm WARN deprecated [email protected]: This SVGO version is no longer supported. Upgrade to v2.x.x.
npm WARN deprecated [email protected]: please switch to a stable version
npm WARN deprecated [email protected]: "Please update to latest v2.3 or v2.2"
npm WARN deprecated [email protected]: This loader has been deprecated. Please use eslint-webpack-plugin
npm WARN deprecated [email protected]: babel-eslint is now @babel/eslint-parser. This package will no longer receive updates.
npm WARN deprecated @material-ui/[email protected]: This package no longer supported. It has been relaced by @mui/x-date-pickers
npm WARN deprecated [email protected]: Critical security vulnerability fixed in v0.21.1. For more information, see https://github.com/axios/axios/pull/3410
npm WARN deprecated @material-ui/[email protected]: Material UI v4 doesn't receive active development since September 2021. See the guide https://mui.com/material-ui/migration/migration-v4/ to upgrade to v5.
npm WARN deprecated @material-ui/[email protected]: Material UI v4 doesn't receive active development since September 2021. See the guide https://mui.com/material-ui/migration/migration-v4/ to upgrade to v5.
npm WARN deprecated [email protected]: Chokidar 2 does not receive security updates since 2019. Upgrade to chokidar 3 with 15x fewer dependencies
npm WARN deprecated [email protected]: The v1 package contains DANGEROUS / INSECURE binaries. Upgrade to safe fsevents v2
npm WARN deprecated [email protected]: The v1 package contains DANGEROUS / INSECURE binaries. Upgrade to safe fsevents v2
npm WARN deprecated [email protected]: The v1 package contains DANGEROUS / INSECURE binaries. Upgrade to safe fsevents v2
npm WARN deprecated [email protected]: core-js@<3.23.3 is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Some versions have web compatibility issues. Please, upgrade your dependencies to the actual version of core-js.
npm WARN deprecated [email protected]: Chokidar 2 does not receive security updates since 2019. Upgrade to chokidar 3 with 15x fewer dependencies
npm WARN deprecated @material-ui/[email protected]: Material UI v4 doesn't receive active development since September 2021. See the guide https://mui.com/material-ui/migration/migration-v4/ to upgrade to v5.

added 1765 packages, and audited 1766 packages in 50s

138 packages are looking for funding
  run `npm fund` for details

123 vulnerabilities (1 low, 97 moderate, 21 high, 4 critical)

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: [email protected]
npm WARN Found: [email protected]
npm WARN node_modules/react-dnd
npm WARN   react-dnd@"^11.1.3" from [email protected]
npm WARN   node_modules/mui-datatables
npm WARN     mui-datatables@"^3.4.1" from the root project
npm WARN   1 more (react-sortable-tree)
npm WARN
npm WARN Could not resolve dependency:
npm WARN peer react-dnd@"^7.3.0" from [email protected]
npm WARN node_modules/frontend-collective-react-dnd-scrollzone
npm WARN   frontend-collective-react-dnd-scrollzone@"^1.0.2" from [email protected]
npm WARN   node_modules/react-sortable-tree
npm WARN
npm WARN Conflicting peer dependency: [email protected]
npm WARN node_modules/react-dnd
npm WARN   peer react-dnd@"^7.3.0" from [email protected]
npm WARN   node_modules/frontend-collective-react-dnd-scrollzone
npm WARN     frontend-collective-react-dnd-scrollzone@"^1.0.2" from [email protected]
npm WARN     node_modules/react-sortable-tree

changed 1 package, and audited 1766 packages in 2s

138 packages are looking for funding
  run `npm fund` for details

123 vulnerabilities (1 low, 97 moderate, 21 high, 4 critical)

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.

> [email protected] build
> react-scripts build

Creating an optimized production build...
Compiled with warnings.

./src/basic-components/Kafka/Topics.js
  Line 16:17:  'Component' is defined but never used             no-unused-vars
  Line 16:28:  'forwardRef' is defined but never used            no-unused-vars
  Line 17:20:  'lazy' is defined but never used                  no-unused-vars
  Line 23:8:   'CreateTopicPanel' is defined but never used      no-unused-vars
  Line 26:7:   'useStyles' is assigned a value but never used    no-unused-vars
  Line 90:10:  'openModal' is assigned a value but never used    no-unused-vars
  Line 92:9:   'handleOpen' is assigned a value but never used   no-unused-vars
  Line 95:9:   'handleClose' is assigned a value but never used  no-unused-vars

./src/basic-components/MemQ/Topics.js
  Line 16:17:  'Component' is defined but never used             no-unused-vars
  Line 16:28:  'forwardRef' is defined but never used            no-unused-vars
  Line 17:20:  'lazy' is defined but never used                  no-unused-vars
  Line 25:7:   'useStyles' is assigned a value but never used    no-unused-vars
  Line 93:10:  'openModal' is assigned a value but never used    no-unused-vars
  Line 95:9:   'handleOpen' is assigned a value but never used   no-unused-vars
  Line 98:9:   'handleClose' is assigned a value but never used  no-unused-vars

./src/basic-components/Kafka/CreateTopicPanel.js
  Line 16:17:  'Suspense' is defined but never used          no-unused-vars
  Line 16:27:  'lazy' is defined but never used              no-unused-vars
  Line 16:33:  'useState' is defined but never used          no-unused-vars
  Line 18:3:   'Box' is defined but never used               no-unused-vars
  Line 27:3:   'FormControlLabel' is defined but never used  no-unused-vars
  Line 28:3:   'Checkbox' is defined but never used          no-unused-vars

./src/basic-components/Kafka/BrokersetPanel.js
  Line 16:17:  'forwardRef' is defined but never used             no-unused-vars
  Line 18:3:   'Paper' is defined but never used                  no-unused-vars
  Line 19:3:   'Grid' is defined but never used                   no-unused-vars
  Line 20:3:   'Table' is defined but never used                  no-unused-vars
  Line 21:3:   'TableBody' is defined but never used              no-unused-vars
  Line 22:3:   'TableCell' is defined but never used              no-unused-vars
  Line 23:3:   'TableContainer' is defined but never used         no-unused-vars
  Line 24:3:   'TableHead' is defined but never used              no-unused-vars
  Line 25:3:   'TableRow' is defined but never used               no-unused-vars
  Line 26:3:   'Typography' is defined but never used             no-unused-vars
  Line 27:3:   'ExpansionPanelDetails' is defined but never used  no-unused-vars
  Line 28:3:   'ExpansionPanelSummary' is defined but never used  no-unused-vars
  Line 29:3:   'ExpansionPanel' is defined but never used         no-unused-vars
  Line 30:3:   'Divider' is defined but never used                no-unused-vars
  Line 31:3:   'Link' is defined but never used                   no-unused-vars
  Line 32:3:   'Box' is defined but never used                    no-unused-vars
  Line 34:8:   'ExpandMoreIcon' is defined but never used         no-unused-vars
  Line 35:18:  'RouterLink' is defined but never used             no-unused-vars
  Line 35:30:  'Redirect' is defined but never used               no-unused-vars
  Line 35:40:  'Route' is defined but never used                  no-unused-vars
  Line 35:47:  'Switch' is defined but never used                 no-unused-vars
  Line 36:10:  'withStyles' is defined but never used             no-unused-vars
  Line 36:22:  'makeStyles' is defined but never used             no-unused-vars
  Line 48:18:  Expected to return a value in arrow function       array-callback-return

./src/basic-components/Kafka/MembersPanel.js
  Line 16:17:  'forwardRef' is defined but never used          no-unused-vars
  Line 21:7:   'clusterId' is assigned a value but never used  no-unused-vars
  Line 29:19:  Expected to return a value in arrow function    array-callback-return

./src/basic-components/Homepage.js
  Line 16:17:  'useEffect' is defined but never used  no-unused-vars

./src/basic-components/Dashboard.js
  Line 18:3:   'Container' is defined but never used           no-unused-vars
  Line 20:3:   'Button' is defined but never used              no-unused-vars
  Line 21:3:   'Chip' is defined but never used                no-unused-vars
  Line 22:3:   'Paper' is defined but never used               no-unused-vars
  Line 24:3:   'Divider' is defined but never used             no-unused-vars
  Line 25:3:   'Box' is defined but never used                 no-unused-vars
  Line 27:8:   'Chart' is defined but never used               no-unused-vars
  Line 28:18:  'RouterLink' is defined but never used          no-unused-vars
  Line 28:30:  'Redirect' is defined but never used            no-unused-vars
  Line 28:40:  'Route' is defined but never used               no-unused-vars
  Line 28:47:  'Switch' is defined but never used              no-unused-vars
  Line 31:7:   'numb' is assigned a value but never used       no-unused-vars
  Line 33:7:   'useStyles' is assigned a value but never used  no-unused-vars
  Line 77:15:  Expected to return a value in arrow function    array-callback-return

./src/basic-components/Commons/PropsTable.js
  Line 18:3:  'Container' is defined but never used              no-unused-vars
  Line 19:3:  'Typography' is defined but never used             no-unused-vars
  Line 20:3:  'Button' is defined but never used                 no-unused-vars
  Line 21:3:  'Chip' is defined but never used                   no-unused-vars
  Line 22:3:  'Paper' is defined but never used                  no-unused-vars
  Line 23:3:  'Grid' is defined but never used                   no-unused-vars
  Line 24:3:  'Table' is defined but never used                  no-unused-vars
  Line 25:3:  'TableBody' is defined but never used              no-unused-vars
  Line 26:3:  'TableCell' is defined but never used              no-unused-vars
  Line 27:3:  'TableContainer' is defined but never used         no-unused-vars
  Line 28:3:  'TableHead' is defined but never used              no-unused-vars
  Line 29:3:  'TablePagination' is defined but never used        no-unused-vars
  Line 30:3:  'TableRow' is defined but never used               no-unused-vars
  Line 31:3:  'ExpansionPanelActions' is defined but never used  no-unused-vars
  Line 32:3:  'Divider' is defined but never used                no-unused-vars
  Line 44:9:  'classes' is assigned a value but never used       no-unused-vars

./src/basic-components/Summary.js
  Line 18:8:   'Chart' is defined but never used       no-unused-vars
  Line 20:10:  'makeStyles' is defined but never used  no-unused-vars
  Line 21:8:   'AlertPanel' is defined but never used  no-unused-vars

./src/basic-components/Kafka/KafkaTopic.js
  Line 19:10:   'makeStyles' is defined but never used        no-unused-vars
  Line 147:22:  Expected to return a value in arrow function  array-callback-return
  Line 207:10:  Expected '!==' and instead saw '!='           eqeqeq

./src/basic-components/Kafka/KafkaNode.js
  Line 19:10:   'makeStyles' is defined but never used        no-unused-vars
  Line 151:34:  Expected to return a value in arrow function  array-callback-return
  Line 188:10:  Expected '!==' and instead saw '!='           eqeqeq

./src/basic-components/Alerts.js
  Line 19:3:  'ExpansionPanelSummary' is defined but never used  no-unused-vars
  Line 20:3:  'ExpansionPanelDetails' is defined but never used  no-unused-vars
  Line 21:3:  'ExpansionPanel' is defined but never used         no-unused-vars
  Line 22:3:  'Grid' is defined but never used                   no-unused-vars
  Line 23:3:  'Chip' is defined but never used                   no-unused-vars
  Line 24:3:  'Typography' is defined but never used             no-unused-vars
  Line 25:3:  'ExpansionPanelActions' is defined but never used  no-unused-vars
  Line 26:3:  'Divider' is defined but never used                no-unused-vars
  Line 27:3:  'Button' is defined but never used                 no-unused-vars

./src/basic-components/Kafka/Brokersets.js
  Line 20:8:  'CreateTopicPanel' is defined but never used  no-unused-vars

./src/basic-components/MemQ/MemqService.js
  Line 22:7:  'useStyles' is assigned a value but never used  no-unused-vars

./src/basic-components/Kafka/KafkaService.js
  Line 24:7:  'useStyles' is assigned a value but never used  no-unused-vars

./src/basic-components/Service.js
  Line 25:3:  Expected a default case  default-case

./src/basic-components/MemQ/MemqTopic.js
  Line 27:10:   'makeStyles' is defined but never used                     no-unused-vars
  Line 102:10:  'getBrokerset' is defined but never used                   no-unused-vars
  Line 134:10:  'getTopicReadPartitionsData' is defined but never used     no-unused-vars
  Line 142:26:  Expected to return a value in arrow function               array-callback-return
  Line 160:10:  'getTopicReadPartitionsColumns' is defined but never used  no-unused-vars
  Line 180:26:  Expected to return a value in arrow function               array-callback-return
  Line 202:11:  'overrideConfigs' is assigned a value but never used       no-unused-vars
  Line 260:10:  Expected '!==' and instead saw '!='                        eqeqeq
  Line 265:10:  'bytesToGB' is defined but never used                      no-unused-vars

./src/basic-components/MemQ/MemqNode.js
  Line 27:10:   'makeStyles' is defined but never used                   no-unused-vars
  Line 133:10:  'nodeToLink' is defined but never used                   no-unused-vars
  Line 141:10:  Expected '!==' and instead saw '!='                      eqeqeq
  Line 146:10:  'getBrokerEnvironmentData' is defined but never used     no-unused-vars
  Line 164:10:  'getBrokerEnvironmentColumns' is defined but never used  no-unused-vars
  Line 171:10:  'getServiceConfigsData' is defined but never used        no-unused-vars
  Line 191:10:  'getServiceConfigsColumns' is defined but never used     no-unused-vars
  Line 225:18:  Expected to return a value in arrow function             array-callback-return

./src/basic-components/HBase/HBaseNode.js
  Line 27:10:   'makeStyles' is defined but never used        no-unused-vars
  Line 165:18:  Expected to return a value in arrow function  array-callback-return
  Line 183:10:  'nodeToLink' is defined but never used        no-unused-vars
  Line 191:10:  Expected '!==' and instead saw '!='           eqeqeq

./src/basic-components/GlobalSensors.js
  Line 27:8:  'ErrorIcon' is defined but never used  no-unused-vars

./src/basic-components/AlertPanel.js
  Line 28:3:  'Paper' is defined but never used  no-unused-vars

./src/basic-components/Nodes.js
  Line 305:13:  'nodeType' is assigned a value but never used  no-unused-vars

./src/basic-components/Cluster.js
  Line 37:10:  'BuildRounded' is defined but never used  no-unused-vars

./src/basic-components/Layout.js
  Line 38:8:  'Summary' is defined but never used  no-unused-vars

./src/basic-components/Kafka/ConsumerGroups.js
  Line 50:16:  Expected to return a value in arrow function  array-callback-return

./src/basic-components/Utilization.js
  Line 74:41:   Expected '===' and instead saw '=='  eqeqeq
  Line 166:13:  'topic' is already defined           no-redeclare
  Line 167:13:  'cost' is already defined            no-redeclare

Search for the keywords to learn more about each warning.
To ignore, add // eslint-disable-next-line to the line before.

File sizes after gzip:

  569.7 KB  build/static/js/2.8da995a5.chunk.js
  16.01 KB  build/static/js/main.e2ac3460.chunk.js
  10.67 KB  build/static/css/2.e1e8f2d4.chunk.css
  1.4 KB    build/static/js/4.c7ff8d22.chunk.js
  1.19 KB   build/static/js/runtime-main.d589926d.js
  1.19 KB   build/static/js/3.77cbf04c.chunk.js
  918 B     build/static/js/5.a595112f.chunk.js
  441 B     build/static/css/main.05aca441.chunk.css

The project was built assuming it is hosted at /.
You can control this with the homepage field in your package.json.

The build folder is ready to be deployed.
You may serve it with a static server:

  npm install -g serve
  serve -s build

Find out more about deployment here:

  bit.ly/CRA-deploy

@brunoasr brunoasr requested a review from a team as a code owner February 21, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@brunoasr