Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle writing all-NA magclass objects in write.report #160

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

fbenke-pik
Copy link
Contributor

@fbenke-pik fbenke-pik commented Nov 10, 2023

prepareData needs to be skipped in that case, as it tries to apply dcast on an empty data table and crashes.
This is only problematic, when NAs should be removed, i.e. skipempty is set to TRUE

Copy link
Member

@tscheypidi tscheypidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for fixing.

Don't forget buildLibrary

@fbenke-pik fbenke-pik merged commit 33ac71f into pik-piam:master Nov 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants