Menu accessibility keyboard access using tab and screen reader #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
May 6, 2019
src/_accessibility.scss
Outdated
| @@ -0,0 +1,3 @@ | |||
| [aria-haspopup="true"]:focus-within .menu { | |||
| display: block; | |||
| } | |||
There was a problem hiding this comment.
Files should end with a trailing newline
src/_accessibility.scss
Outdated
| @@ -0,0 +1,3 @@ | |||
| [aria-haspopup="true"]:focus-within .menu { | |||
| display: block; | |||
There was a problem hiding this comment.
Line should be indented 2 spaces, but was indented 4 spaces
Repository owner
deleted a comment from
lu4p
Jul 1, 2020
|
It was an effort to keep the sub menu items open when using the keyboard to
navigate.
I came across this issue when doing accessibility testing with a
screenreader. I was unable to have sub menu items read aloud.
Cheers,
Lee
…On Thu, 2 Jul 2020, 4:19 am lu4p, ***@***.***> wrote:
@leejsinclair <https://github.com/leejsinclair> I would like to merge
this into my https://github.com/lu4p/specter fork I actively maintain.
Can you elaborate what this exactly does?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#590 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFMYWZ4OJOCAB46QNPNVRDRZN42DANCNFSM4HK4SREQ>
.
|
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.