Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore line 34,duplicate call #25

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

ignore line 34,duplicate call #25

wants to merge 7 commits into from

Conversation

warjiang
Copy link

may you don't mentioned line 34,within src/angular-fontawesome.js

//line 34
_observeStringAttr('stack');
//line 56
attrs.$observe('stack', function () {
})

warjiang and others added 7 commits September 14, 2016 10:11
@warjiang
ignore line 34,duplicate call
37e86bc
@warjiang
remove duplicate invoke in directive fa and faStack,add util fact…
f1e9df1 
…ory and merge _observeStringAttr、_observeNumberAttr、_observeBooleanAttr、_observeAltAttr into _observeAttrWrapper,use _observeAttr identify different attribute and call different function
@warjiang
revert attrs.$observer
67d3517
@warjiang
test travis
7a0e5e7
@warjiang
use grunt test-suite
ad8806c
@warjiang
local test
72564e4
remove some comment
5778c0f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@warjiang