Make customArrows option be accessed through all events #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Flickity Responsive doesn't hide custom arrows when the slider is not slideable while we already had this function.
Why
In the responsive-navigation function, we only hide the
customArrows
throughoptions.customArrows
, but this option is created inonMatched
event and we invoke this function insideonLoad
andonResize
events. So that we don't have anything change.And a small notice that the object between each event is different in memory. So that the customArrows option that we created in
onMatched
doesn't exist inonLoad
andonResize
events.Solution
customArrows
to be part of theFlickity instance
, so that it will be accessed through all the events (onLoad
,onMatched
,onResize
).