Merge pull request #145 from iMattPro/updates

Maintenance
phpbb-extensions · Jul 5, 2024 · 5343eb5 · 5343eb5
2 parents d13a6f1 + f56e4f9
commit 5343eb5
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 5 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -127,6 +127,8 @@ jobs:
                       db: "mysql:5.7"
                     - php: '8.3'
                       db: "mysql:5.7"
+                    - php: '8.4'
+                      db: "mysql:5.7"
 
         name: PHP ${{ matrix.php }} - ${{ matrix.db_alias != '' && matrix.db_alias || matrix.db }}
 
@@ -270,6 +272,8 @@ jobs:
                       db: "postgres:14"
                     - php: '8.3'
                       db: "postgres:14"
+                    - php: '8.4'
+                      db: "postgres:14"
 
         name: PHP ${{ matrix.php }} - ${{ matrix.db }}
 

diff --git a/ext.php b/ext.php
@@ -64,7 +64,7 @@ protected function phpbb_requirement()
 	 */
 	protected function php_requirement()
 	{
-		if (phpbb_version_compare(PHP_VERSION, '5.6.0', '<'))
+		if (PHP_VERSION_ID < 50600)
 		{
 			$this->errors[] = 'PHP_VERSION_ERROR';
 		}

diff --git a/skeleton/.github/workflows/tests.yml.twig b/skeleton/.github/workflows/tests.yml.twig
@@ -125,8 +125,10 @@ jobs:
                       db: "mysql:5.7"
                     - php: '8.2'
                       db: "mysql:5.7"
-					- php: '8.3'
-					  db: "mysql:5.7"
+                    - php: '8.3'
+                      db: "mysql:5.7"
+                    - php: '8.4'
+                      db: "mysql:5.7"
 
         name: PHP ${{ '{{' }} matrix.php }} - ${{ '{{' }} matrix.db_alias != '' && matrix.db_alias || matrix.db }}
 
@@ -237,8 +239,10 @@ jobs:
                       db: "postgres:14"
                     - php: '8.2'
                       db: "postgres:14"
-					- php: '8.3'
-					  db: "postgres:14"
+                    - php: '8.3'
+                      db: "postgres:14"
+                    - php: '8.4'
+                      db: "postgres:14"
 
         name: PHP ${{ '{{' }} matrix.php }} - ${{ '{{' }} matrix.db }}