Simplify usage of FileParserFactory #408
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By allowing createFileParser to be called with null we need less code everywhere else to create a default file parser.
| public static function createFileParser(TargetPhpVersion $targetPhpVersion, bool $parseCustomAnnotations = true): FileParser | ||
| { | ||
| public static function createFileParser( | ||
| TargetPhpVersion $targetPhpVersion = null, |
There was a problem hiding this comment.
Suggested change
| TargetPhpVersion $targetPhpVersion = null, | |
| ?TargetPhpVersion $targetPhpVersion = null, |
I assume this should be explicitly marked as a nullable type instead of depending on implicit PHP behaviour.
| @@ -26,7 +26,7 @@ private function __construct(?string $version) | |||
| $this->version = $version; | |||
| } | |||
|
|
|||
| public static function create(?string $version): self | |||
| public static function create(string $version = null): self | |||
There was a problem hiding this comment.
Suggested change
| public static function create(string $version = null): self | |
| public static function create(?string $version = null): self |
as above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By allowing createFileParser to be called with null we need less code everywhere else to create a default file parser.