Allow architectures to be created from expressions #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hgraca
force-pushed
the
feat/architecture_from_expression
branch
2 times, most recently
from
b4ef086
to
38d4a4a
Compare
|
That's really cool, it is much more coherent with the rest of design than the way we are doing it now... |
This will allow for complex nested expressions, like ANDs inside ORs.
This will reduce the amount of expressions needed and allow for complex expressions (within an OR or an AND) to be negated.
hgraca
force-pushed
the
feat/architecture_from_expression
branch
from
38d4a4a
to
7c34636
Compare
hgraca
force-pushed
the
feat/architecture_from_expression
branch
from
7c34636
to
134765d
Compare
|
@fain182 the issues should be fixed (cant tell cozz the build isn't running) can you check if there's something more to do pls? |
To improve understanding of mayDependOnComponents and shouldOnlyDependOnComponents
This simplifies expressions and makes them more predictable.
This will allow for composable and more complex rules.
hgraca
force-pushed
the
feat/architecture_from_expression
branch
from
134765d
to
2f39bc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow for composable and more complex rules.
DEPENDS ON #394 #395
Only the last commit is relevant for this PR.