Pass url into curlinfo hook for effective url #364
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Issue #363
When checking for errors in a
curl_multi
I pull the effective url to log with the error.Which currently fails with php-vcr
IMHO it really should just return the request url parameter from the source YAML.
What has been done
getCurlOptionFromResponse
to pass in the URL (or null)self::$requests
array of VCR\Request objectsHow to test
request -> url
parameterTodo
Notes