Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for fractional seconds timeout #55

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented Jul 30, 2023

  • usleep supports microseconds resolution
  • Redis support milliseconds expire times

The changed method prototypes imply minor BC break if overriden, but no BC break in general, as float does accept (original) int values implicitly even with strict types.

@willemstuursma
Copy link
Contributor

Hi, thank you for this MR. I was a on a holiday, but I'll have a look!

@willemstuursma
Copy link
Contributor

Had a quick look, looks pretty fine, I'll have a closer look later this week.

Thank you, a very nice contribution!

@mvorisek
Copy link
Contributor Author

@willemstuursma may I please ask to review this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants