Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: do not delete folders flag #4092

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

zhzy0077
Copy link

@zhzy0077 zhzy0077 commented Mar 7, 2024

  • What does it implement / fix / improve? Why?
    For Synology Cloud Sync, it fails to sync to the WebDav when the folder doesn't exist. It won't create folders as part of the incremental sync. As a result, people see
2024-03-07 21:16:00 ERRO webdav: 'open /photoprism/import/x.jpg: no such file or directory' in PUT /import/x.jpg

The changes in this PR allow user to set a configuration to stop deleting empty folders after import.

  • Are the changes related to an existing issue?
    No.

Acceptance Criteria:

  • Features and enhancements must be fully implemented so that they can be released at any time without additional work
  • Automated unit and/or acceptance tests are mandatory to ensure the changes work as expected and to reduce repetitive manual work
  • Frontend components must be responsive to work and look properly on phones, tablets, and desktop computers; you must have tested them on all major browsers and different devices
  • Documentation and translation updates should be provided if needed
  • In case you submit database-related changes, they must be tested and compatible with SQLite 3 and MariaDB 10.5.12+

@CLAassistant
Copy link

CLAassistant commented Mar 7, 2024

CLA assistant check
All committers have signed the CLA.

@graciousgrey
Copy link
Member

Thank you very much for your contribution. We will review it as soon as our time allows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants