Merge pull request #2 from philmander/log-line-numbers

Log line numbers
philmander · Aug 2, 2016 · bf72d81 · bf72d81
2 parents e8b8ee9 + 0dd9ee4
commit bf72d81
Show file tree

Hide file tree

Showing 4 changed files with 38 additions and 19 deletions.
diff --git a/README.md b/README.md
@@ -7,19 +7,38 @@ The code also contains a dedicated browser console stream. Use it like this:
 ```javascript
 var bunyan = require('./lib/bunyan');
 var log = bunyan.createLogger({
-    name: 'play',
+    name: 'myLogger',
     streams: [
         {
             level: 'info',
             stream: new bunyan.ConsoleFormattedStream()
             type: 'raw'
         }
-    ]
+    ],
+    src: true
 });
 
 log.info('hi on info');
 ```
 
+Angular example:
+
+```javascript
+adminApp.config(function($provide) {
+    $provide.decorator('$log', function($delegate) {
+        $delegate = bunyan.createLogger({
+            name: 'myLogger',
+            streams: [{
+                level: 'info',
+                stream: new bunyan.ConsoleFormattedStream(),
+                type: 'raw'
+            }]
+        });
+        return $delegate;
+    });
+});
+```
+
 Docs are the Bunyan docs at time of forking, with the documentation for the stripped features also removed:
 
 =====================================

diff --git a/dist/browser-bunyan.js b/dist/browser-bunyan.js
@@ -12,7 +12,7 @@
  * -*- mode: js -*-
  * vim: expandtab:ts=4:sw=4
  */
-
+    
 'use strict';
 
 var VERSION = '0.2.3';
@@ -227,7 +227,6 @@ Object.keys(levelFromName).forEach(function (name) {
     nameFromLevel[levelFromName[name]] = name;
 });
 
-
 /**
  * Resolve a level number, name (upper or lowercase) to a level number value.
  *
@@ -238,7 +237,6 @@ function resolveLevel(nameOrNum) {
     return level;
 }
 
-
 //---- Logger class
 
 /**
@@ -771,16 +769,18 @@ function mkLogEmitter(minLevel) {
             }
             // Get call source info
             if (log.src && !rec.src) {
-                var src = extractSrcFromStacktrace(new Error(CALL_STACK_ERROR).stack, 2);
-                if(!src) {
-                    if(!_haveWarned('src')) {
+                try {
+                    //need to throw the error so there is a stack in IE		 	
+                    throw new Error(CALL_STACK_ERROR);
+                } catch(err) {
+                    var src = extractSrcFromStacktrace(err.stack, 2);
+                    if(!src && !_haveWarned('src')) {
                         _warn('Unable to determine src line info', 'src');    
                     }
+                    rec.src = src || '';
                 }
-                rec.src = src || '';
             }
             rec.v = LOG_VERSION;
-
             return rec;
         }