Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

random numbers & mail notify on project description change #70

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

pikkewyn
Copy link

Hi!
To last changes I've added mail notification after changing project description.

@evaK-de
Copy link
Collaborator

evaK-de commented Dec 15, 2014

Looks interesting and this e-mail notifiction should definitely be added. :)

Could you modify your pull request regarding the following points, please?

  1. Exclude the changes in class.datei.php to keep separate changes in separate pull requests.
  2. Remove lines 97-98 from your changes in manageproject.php since those seem to be copy&paste artifacts.
  3. Ideally you would add a new string to the language file ("en" should be sufficient for now) instead of reusing "projectwasedited" in the subject. There is a specific format for this, like e.g. "Collabtive notification: New message".

@pikkewyn
Copy link
Author

Hi, I'm glad to help :) I've removed this part regarding filenames leaving only email notification about project description change.

@pikkewyn pikkewyn closed this Dec 23, 2014
@pikkewyn pikkewyn reopened this Dec 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants