Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced uniqid with a uuid function. #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jerryq27
Copy link

Did some research on the uniqid(); function, and the chance for a conflict seems a bit high. I've also came across this post discussing the issues with it.

I can't take credit for the UUID code in my pull request. I found this answer when researching a PHP function to generate UUID's.

Another option is to use the WordPress wp_generate_uuid4 function, but the code from Stack Overflow doesn't seem as reliant on WordPress, though since this is a package for ACF, that probably doesn't matter.

Hope you pull in my changes or consider using a different function to generate these IDs!

The chance of a conflict with uniqid(); are a bit higher than I'm comfortable with.
@scrobbleme
Copy link

scrobbleme commented Jun 14, 2024

There is also wp_unique_id() which takes a prefix, so i.e. acf-uuid- would make it even less unique. Or just use something like data('Ymd') as prefix.

I really wouldn't care about collisions here...

Edit: Ah, the field value is the UUID... so the prefix might be an field option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants