Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use libsepol source rather than compiled libs #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use libsepol source rather than compiled libs #6

wants to merge 2 commits into from

Conversation

superr
Copy link
Contributor

@superr superr commented Nov 11, 2015

Not sure if this is of interest to you, but I switched to using libsepol source rather than the pre-compiled libs.

@phhusson
Copy link
Owner

I could be interested, but I'd rather have it as a git submodule, than blindly importing 32k lines in a small project

@superr
Copy link
Contributor Author

superr commented Nov 11, 2015

Feel free to do whatever you like with it. This works well for my project so I thought I would let you know. I am not familiar with git submodules so if it is better go for it :)

The source is the newest AOSP from the master branch fyi. I stripped out most of the unneeded bits to make it smaller.

https://android.googlesource.com/platform/external/libsepol/+/master

@lbdroid
Copy link

lbdroid commented Nov 12, 2015

Any particular reason not to just pull in the actual AOSP repository as a submodule?

All that would have to be done, is to write to or append makefiles in the sepolicy-inject project (outside of the submodule) to build the objects.

@superr
Copy link
Contributor Author

superr commented Nov 12, 2015

In my case, I am including the source in my Android Kitchen to build when it is needed and want to keep the size as small as possible. Again, I am not familiar with submodules and I am not sure if it will suit my needs.

@lbdroid
Copy link

lbdroid commented Nov 12, 2015

Well, the suggestion is more for this upstream repository than your downstream.

But for your own personal use, you really should look into submodules. They are pretty easy to deal with and make life a whole lot easier.

Basically what a submodule is, is a directory within the main project that is designated to contain some other project, and at a specific revision. Your submodule will stick to the original revision that you originally tied up to, in order to prevent random breakage and allow you to step forward with the subproject's advancements in a controlled manner.

Here is a howto; https://chrisjean.com/git-submodules-adding-using-removing-and-updating/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants