fixing protobuf mergeFromJsonString stub #4840
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since protobuf v3.13 (protocolbuffers/protobuf#7695 about 4 years ago) Google\Protobuf\Internal\Message::mergeFromJsonString has an optional second boolean parameter.
the parameter has a different name in native vs extension :(
|
Currently, when running phan on php 8.0+ when supplying the second parameter and using the protobuf extension (but not the native library), this results in a LMK if this needs a test. It looks like that would require adding the protobuf extension into the dockerfile that the tests are run against (which would impact build times). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since protobuf v3.13 (protocolbuffers/protobuf#7695 about 4 years ago) Google\Protobuf\Internal\Message::mergeFromJsonString has an optional second boolean parameter.