Report variables overwritten across multiple branches differently from those unused or overwritten in one branch #4601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arichard4
force-pushed
the
branch_unused
branch
3 times, most recently
from
b04ff03
to
ecea7b3
Compare
…m those unused or overwritten in one branch Closes phan#4600
arichard4
force-pushed
the
branch_unused
branch
from
ecea7b3
to
0877414
Compare
|
My previous comment that unused variables in try/catch blocks weren't being usefully reported, so I shouldn't exclude them here, was wrong as of #4567 I'd been working on top of 5.2.1 instead of tip of V5 and so didn't include that. I've now accounted for try/catch blocks and added a test for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #4600