Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helm lint action #1589

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Conversation

MindTooth
Copy link
Contributor

@MindTooth MindTooth commented Oct 31, 2023

Description

Second attempt with newer version. Supersedes #1569.

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've written tests (if applicable) for all new methods and classes that I created. (rake test)
  • I've added documentation as necessary so users can easily use and understand this feature/fix.

@MindTooth
Copy link
Contributor Author

Seeing as it does not work. I posted a comment to an issue someone else has reported too. helm/chart-testing-action#108

@MindTooth
Copy link
Contributor Author

@pglombardo is this something that you would accept now that it works?

@pglombardo
Copy link
Owner

@pglombardo is this something that you would accept now that it works?

Absolutely and much appreciated! Give me a bit to get some time and go through the PR (and learn the Helm basics).

@pglombardo
Copy link
Owner

Looks good to me @MindTooth. Should we (or is there any value) in publishing these Helm charts to ArtifactHub?

@MindTooth
Copy link
Contributor Author

Maybe host ourself using https://github.com/helm/chart-releaser? Can then forgo any need for auth against ArtifactHub. 🤷🏻‍♂️

@MindTooth MindTooth marked this pull request as ready for review November 14, 2023 07:48
@MindTooth
Copy link
Contributor Author

We should also update it with all parameters as of late. Can do that when this is merged. Start to treat helm as a valid option.

@MindTooth MindTooth force-pushed the ci/add_helm_lint_action branch 2 times, most recently from a956ccc to a0efbba Compare December 15, 2023 16:50
@pglombardo
Copy link
Owner

This is slick now that I've had the time to look at it 😄

Thanks @MindTooth

@pglombardo pglombardo merged commit 2e8e38c into pglombardo:master Jun 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants