Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpine conversion due to Debian Critical Vulns #534

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

devine12
Copy link

@devine12 devine12 commented Jan 9, 2024

Fixes Issue

Fixes #513

Changes proposed

Changes debian base images to alpine in the dockerfile

Change asyncio.wait to asyncio.gather in the client engine due to continuous restarting.

ddtrace package requires update to install within alpine

Check List (Check all the applicable boxes)

  • I sign off on contributing this submission to open-source
  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Copy link

netlify bot commented Jan 9, 2024

Deploy Preview for opal-docs ready!

Name Link
🔨 Latest commit 8171e77
🔍 Latest deploy log https://app.netlify.com/sites/opal-docs/deploys/659ca31e94ccd4000808a21e
😎 Deploy Preview https://deploy-preview-534--opal-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -1,14 +1,18 @@
# BUILD STAGE ---------------------------------------
# split this stage to save time and reduce image size
# ---------------------------------------------------
FROM python:3.10-bullseye as BuildStage
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @devine12 thanks for the contribution, can you create a folder community inside the docker folder and add there your changes?
We would love to add it but we don't want to break it for people that using this docker and don't want to update their base image (no internet connection etc..)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, the base image can be a docker build ARG.
Then we can build & publish both for each version

@roekatz
Copy link
Contributor

roekatz commented Apr 30, 2024

For now making it a draft PR.
@devine12 - We don't want your work to get loss, lmk if you want to complete the work here (adding alpine as another option rather than replacing Debian all together). If not, I'll try finding the time to do it myself.

@roekatz roekatz marked this pull request as draft April 30, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Base image vulnerabilities
3 participants