Added 'suite.wasDefined' and 'test.added' event emissions from Context

[ghost]

@brianium, here's the previously-discussed pull request for a couple new event emissions from core to aid in the Scenarios plugin implementation. Please let me know if there are any issues or if anything further is needed...thanks!

Josh

[ezzatron]

Thanks for the PR! I've just recently come on as a maintainer here, and I might be able to help out in getting this merged.

Could you help me out with a brief description of what the new events are, and specifically how they differ from, or relate to, any similar existing events? I'm not familiar with the Scenarios plugin, so this would really help me to understand the PR better. A couple of tests would help to convey the intent also.

Cheers!

[ghost]

Sure thing! My apologies...even though the changes are fairly trivial, tests should most certainly have been added before opening the PR. The changes include a new 'suite.wasDefined' event fired immediately after a suite's definition function is executed. I believe there was a pre-existing 'suite.define' event that fired immediately before the suite definition function was executed. Also included is a new 'test.added' event that fires when a test is added to the currently-active suite. I don't believe this new event has any related pre-existing events. Both of these new events are used to capture information for the Scenarios plugin to be able to tell when the context is in a proper state for a scenario to be added (scenarios are always added to the last-added test as defined by a call to the it() function). Each time the plugin is pinged with a 'suite.define' or 'suite.wasDefined', the plugin is put into a state where any attempt to add a scenario throws an error as scenarios are bound to tests, not suites. A ping with the 'test.added' event puts the plugin into a scenario-accepting state.

Feel free to check out the Scenarios plugin repo for more details and let me know if there are any further Q's, will be happy to answer!

Thanks!
Josh

[ezzatron]

Ah, okay, so this is to support peridot-php/peridot#183?

[ghost]

Correct

[ghost]

Just wanted to do a quick follow-up here...if anything further is needed from me, just let me know just let me know and I'll get back to you ASAP!

[ezzatron]

We're tackling a bit of a backlog and some technical issues with our release process at the moment, sorry. I haven't forgotten about this PR, though.

[ghost]

No worries at all, thanks for the quick reply!