Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PG-564: Added a column to display bind variables when used with the n… #350

Open
wants to merge 31 commits into
base: main
Choose a base branch
from

Conversation

kayform
Copy link

@kayform kayform commented Jan 9, 2023

…ormalized_query option.

When collecting data for monitoring, display it as placeholders using the pgsm_normalized_query option.
If bind parameter and "normalized query are retrieved together as attached the image, it would be more useful for query performance analysis.

@ibrarahmad ibrarahmad added the enhancement New feature or request label Jan 9, 2023
…ormalized_query option.\n add regression test
@ImTheKai ImTheKai mentioned this pull request Jan 17, 2023
Copy link
Contributor

@ibrarahmad ibrarahmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some test cases for that.

Copy link
Contributor

@ibrarahmad ibrarahmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pg_stat_monitor-1.0-2.0.sql need to be updated

@kayform kayform requested review from ibrarahmad and removed request for codeforall and hqakhtar February 10, 2023 02:04
@it-percona-cla
Copy link

it-percona-cla commented Mar 14, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ ksjj97inzent
✅ kayform
❌ snsjeong


snsjeong seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants