-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8SPXC-1274: add .spec.initContainer
to PerconaXtraDBCluster
#1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pooknull
requested review from
tplavcic,
nmarukovich,
ptankov,
hors,
egegunes and
inelpandzic
as code owners
October 27, 2023 13:36
inelpandzic
previously approved these changes
Oct 30, 2023
egegunes
requested changes
Oct 30, 2023
pull-request-size
bot
added
size/L
100-499 lines
and removed
size/XL
500-999 lines
labels
Oct 30, 2023
pull-request-size
bot
added
size/XXL
1000+ lines
and removed
size/L
100-499 lines
labels
Oct 31, 2023
pooknull
changed the title
K8SPXC-1274: add
K8SPXC-1274: add Nov 1, 2023
.spec.initResources
to PerconaXtraDBCluster
.spec.initContainer
to PerconaXtraDBCluster
commit: c73a219 |
egegunes
approved these changes
Nov 3, 2023
inelpandzic
approved these changes
Nov 3, 2023
nmarukovich
approved these changes
Nov 3, 2023
hors
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.percona.com/browse/K8SPXC-1274
DESCRIPTION
Problem:
The init container inherits the resource requirements of PXC nodes.
Cause:
Init container doesn't have its own field for resources.
Solution:
Add
.spec.initContainer.resources
toPerconaXtraDBCluster
CHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
compare/*-oc.yml
)?Config/Logging/Testability