Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8SPXC-1274: add .spec.initContainer to PerconaXtraDBCluster #1507

Merged
merged 9 commits into from
Nov 3, 2023

Conversation

pooknull
Copy link
Contributor

@pooknull pooknull commented Oct 27, 2023

K8SPXC-1274 Powered by Pull Request Badge

https://jira.percona.com/browse/K8SPXC-1274

DESCRIPTION

Problem:
The init container inherits the resource requirements of PXC nodes.

Cause:
Init container doesn't have its own field for resources.

Solution:
Add .spec.initContainer.resources to PerconaXtraDBCluster

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?
  • Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are the manifests (crd/bundle) regenerated if needed?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PXC version?
  • Does the change support oldest and newest supported Kubernetes version?

inelpandzic
inelpandzic previously approved these changes Oct 30, 2023
pkg/controller/pxc/controller.go Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/L 100-499 lines and removed size/XL 500-999 lines labels Oct 30, 2023
@pull-request-size pull-request-size bot added size/XXL 1000+ lines and removed size/L 100-499 lines labels Oct 31, 2023
@pooknull pooknull changed the title K8SPXC-1274: add .spec.initResources to PerconaXtraDBCluster K8SPXC-1274: add .spec.initContainer to PerconaXtraDBCluster Nov 1, 2023
@JNKPercona
Copy link
Collaborator

Test name Status
affinity-8-0 passed
auto-tuning-8-0 passed
cross-site-8-0 failure
demand-backup-cloud-8-0 passed
demand-backup-encrypted-with-tls-8-0 passed
demand-backup-8-0 passed
haproxy-5-7 passed
haproxy-8-0 passed
init-deploy-5-7 passed
init-deploy-8-0 passed
limits-8-0 passed
monitoring-2-0-8-0 passed
one-pod-5-7 passed
one-pod-8-0 passed
pitr-8-0 passed
pitr-gap-errors-8-0 passed
proxy-protocol-8-0 passed
proxysql-sidecar-res-limits-8-0 passed
recreate-8-0 passed
restore-to-encrypted-cluster-8-0 passed
scaling-proxysql-8-0 passed
scaling-8-0 passed
scheduled-backup-5-7 passed
scheduled-backup-8-0 failure
security-context-8-0 passed
smart-update1-8-0 passed
smart-update2-8-0 passed
storage-8-0 passed
tls-issue-cert-manager-ref-8-0 passed
tls-issue-cert-manager-8-0 passed
tls-issue-self-8-0 passed
upgrade-consistency-8-0 passed
upgrade-haproxy-8-0 passed
upgrade-proxysql-8-0 passed
users-5-7 passed
users-8-0 passed
validation-hook-8-0 passed
We run 37 out of 37

commit: c73a219
image: perconalab/percona-xtradb-cluster-operator:PR-1507-c73a219e

@hors hors merged commit 8ea6664 into main Nov 3, 2023
10 checks passed
@hors hors deleted the dev/K8SPXC-1274 branch November 3, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL 1000+ lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants