Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pt-config-diff: MySQL truncates run-time variable values longer than 1024 characters #890

Open
wants to merge 1 commit into
base: 3.x
Choose a base branch
from

Conversation

dbnski
Copy link

@dbnski dbnski commented Dec 4, 2024

pt-config-diff relies on SHOW GLOBAL VARIABLES for listing run-time variables. MySQL 5.7 and newer implement the command by reading the contents of the performance_schema table called global_variables, but the table definition uses VARCHAR(1024) for the value field. Any value longer than 1024 characters becomes truncated both in the table as well as in the SHOW GLOBAL VARIABLES command output. This makes comparing long run-time variables unreliable. The patch works around the problem by reading full values from the @@global object whenever necessary.

@dbnski dbnski requested a review from svetasmirnova as a code owner December 4, 2024 07:36
@it-percona-cla
Copy link

it-percona-cla commented Dec 4, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants