pt-config-diff: MySQL truncates run-time variable values longer than 1024 characters #890
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pt-config-diff
relies onSHOW GLOBAL VARIABLES
for listing run-time variables. MySQL 5.7 and newer implement the command by reading the contents of theperformance_schema
table calledglobal_variables
, but the table definition usesVARCHAR(1024)
for the value field. Any value longer than 1024 characters becomes truncated both in the table as well as in theSHOW GLOBAL VARIABLES
command output. This makes comparing long run-time variables unreliable. The patch works around the problem by reading full values from the@@global
object whenever necessary.