Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed flaky tests #862

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

hpoettker
Copy link
Contributor

@hpoettker hpoettker commented Sep 11, 2024

The tests previously tested assertions against the replica after executing changes in the source without waiting for the replication to converge.

At least on my machine, the tests currently fail at least a couple of times when executed in loops like

for i in $(seq 10); do prove t/pt-table-sync/pt-1256.t; done

or

for i in $(seq 10); do prove t/pt-table-sync/char_chunking.t; done

The code is my own creation and it can be distributed under the GPL2 licence.

  • The contributed code is licensed under GPL v2.0
  • Contributor Licence Agreement (CLA) is signed
  • util/update-modules has been ran
  • Documentation updated
  • Test suite update

@hpoettker hpoettker force-pushed the fix_flaky_test_pt_1256 branch from f5be101 to 61c43b4 Compare September 11, 2024 11:24
@hpoettker hpoettker changed the title Fixed flaky test Fixed flaky tests Sep 11, 2024
@hpoettker hpoettker force-pushed the fix_flaky_test_pt_1256 branch from 61c43b4 to dbed839 Compare September 11, 2024 11:48
The tests previously tested assertions against the replica after
executing changes in the source without waiting for the
replication to converge.
@hpoettker hpoettker force-pushed the fix_flaky_test_pt_1256 branch from dbed839 to f8d736a Compare November 14, 2024 22:01
@hpoettker
Copy link
Contributor Author

Thanks so much for the massive effort to adjust the code base to MySQL 8.4!

I've rebased the changes on the latest commit in 3.x.

@svetasmirnova svetasmirnova merged commit 446896d into percona:3.x Dec 2, 2024
5 of 6 checks passed
@hpoettker hpoettker deleted the fix_flaky_test_pt_1256 branch December 2, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants