Support adding explain output for slow query in JSON report as well #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
svetasmirnova
requested changes
Sep 13, 2022
There was a problem hiding this comment.
You changed the auto-generated part of the bin/pt-query-digest code. These changes will be overwritten once we rebuild the tool using the update-modules utility. Please make changes in the package JSONReportFormatter instead.
Please, also add the test case. You will find examples in the directory t.
…as well - Put fix into the proper place - Added test cases
svetasmirnova
approved these changes
Nov 6, 2023
EvgeniyPatlan
approved these changes
Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am generating JSON reports from slow logs and consuming them for a visual dashboard in elasticsearch.
I find it useful to add the EXPLAIN output in the JSON reports as well.