PS-9581 fix: ALTER INSTANCE RELOAD TLS results in a very long execution (WIP) #5524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on (WIP) https://perconadev.atlassian.net/browse/PS-9581 Reworked 'Ssl_acceptor_context_container' / 'Lock_and_access_ssl_acceptor_context' - we now use 'std::shared_ptr' to extend SSL context lifetime.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| if (!context.have_ssl()) return packet_error; | ||
| DBUG_PRINT("info", ("IO layer change in progress...")); | ||
| if (sslaccept(context.get_vio_ssl_fd(), protocol->get_vio(), | ||
| protocol->get_net()->read_timeout, &errptr)) { |
There was a problem hiding this comment.
implicit conversion int -> bool
Suggested change
| protocol->get_net()->read_timeout, &errptr)) { | |
| protocol->get_net()->read_timeout, &errptr) != 0) { |
| Lock_and_access_ssl_acceptor_context(Ssl_acceptor_context_container *context) | ||
| : read_lock_(context->lock_) {} | ||
| ~Lock_and_access_ssl_acceptor_context() = default; | ||
| Lock_and_access_ssl_acceptor_context_data( |
There was a problem hiding this comment.
single-argument constructors must be marked explicit to avoid unintentional implicit conversions
Suggested change
| Lock_and_access_ssl_acceptor_context_data( | |
| explicit Lock_and_access_ssl_acceptor_context_data( |
| @@ -54,8 +54,8 @@ class Ssl_acceptor_context_iterator { | |||
| public: | |||
| using Ssl_acceptor_context_iterator_data_container = | |||
| std::vector<Ssl_acceptor_context_iterator_data>; | |||
| Ssl_acceptor_context_iterator(Ssl_acceptor_context_container *context_type) { | |||
| Lock_and_access_ssl_acceptor_context context(context_type); | |||
| Ssl_acceptor_context_iterator(const Ssl_acceptor_context_data_ptr &data) { | |||
There was a problem hiding this comment.
single-argument constructors must be marked explicit to avoid unintentional implicit conversions
Suggested change
| Ssl_acceptor_context_iterator(const Ssl_acceptor_context_data_ptr &data) { | |
| explicit Ssl_acceptor_context_iterator(const Ssl_acceptor_context_data_ptr &data) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/PS-9581