Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8SPG-628: Allow overriding restore_command #955

Merged
merged 7 commits into from
Dec 17, 2024
Merged

K8SPG-628: Allow overriding restore_command #955

merged 7 commits into from
Dec 17, 2024

Conversation

egegunes
Copy link
Contributor

@egegunes egegunes commented Nov 21, 2024

K8SPG-628 Powered by Pull Request Badge

CHANGE DESCRIPTION

Problem:
In some cases users need to override the restore_command for recovery purposes. Operator doesn't let users to do this.

Solution:
Allow users to override restore_command using dynamicConfiguration field.

Also, this PR adds some missing code from upstream.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PG version?
  • Does the change support oldest and newest supported Kubernetes version?

@egegunes egegunes added this to the v2.6.0 milestone Nov 25, 2024
@egegunes egegunes marked this pull request as ready for review December 13, 2024 09:53
inelpandzic
inelpandzic previously approved these changes Dec 16, 2024
hors
hors previously approved these changes Dec 17, 2024
@egegunes egegunes dismissed stale reviews from hors and inelpandzic via 02b8f1c December 17, 2024 13:11
@JNKPercona
Copy link
Collaborator

Test name Status
custom-extensions passed
custom-tls passed
demand-backup passed
finalizers passed
init-deploy passed
monitoring passed
one-pod passed
operator-self-healing passed
pitr passed
scaling passed
scheduled-backup passed
self-healing passed
sidecars passed
start-from-backup passed
tablespaces passed
telemetry-transfer passed
upgrade-consistency passed
upgrade-minor passed
users passed
We run 19 out of 19

commit: 02b8f1c
image: perconalab/percona-postgresql-operator:PR-955-02b8f1c0d

@hors hors merged commit cc4d16a into main Dec 17, 2024
13 of 14 checks passed
@hors hors deleted the K8SPG-628 branch December 17, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants