-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EVEREST-1511 | support for deploying default DB namespace during installation #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
mayankshah1607
changed the title
EVEREST-1511
EVEREST-1511 | support for deploying default DB engine during installation
Nov 22, 2024
mayankshah1607
changed the title
EVEREST-1511 | support for deploying default DB engine during installation
EVEREST-1511 | support for deploying default DB namespace during installation
Nov 22, 2024
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
mayankshah1607
requested review from
a team,
hors,
tplavcic,
nmarukovich,
ptankov,
jvpasinatto and
eleo007
as code owners
November 26, 2024 09:00
recharte
reviewed
Nov 26, 2024
Signed-off-by: Mayank Shah <[email protected]>
Co-authored-by: Diogo Recharte <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
recharte
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings 2 big improvements:
1. Deploy a default DB namespace along with the core chart installation:
everest
DB namespace will be deployed along with the core chart installationdbNamespace.enabled=false
dbNamespace.namespaceOverride
pxc|pg|psmdb=false
2. No longer need to manually create the namespace object before installing DB namespace
app.kubernetes.io/managed-by=everest
labelSee the updated README for full info.