PMM-7 Check target branch when checking out UI tests #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matejkubinec
added a commit
to percona/pmm-ui-tests
that referenced
this pull request
Dec 13, 2024
Fixes product tour test failures due to the update modal appearing. Once PMM-13608 is fixed it would be better to disable updates through settings rather than to rely on the snoozed pmm version. Related: percona/grafana#791
saikumar-vs
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Use target PR branch as base for the UI tests if available. The order is now following:
PMM-7-ui-tests-target-branch)v3)UI Tests fix: percona/pmm-ui-tests#911