Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PMM-13548 Add service node selection fixes #787

Merged
merged 3 commits into from
Dec 18, 2024
Merged

PMM-13548 Add service node selection fixes #787

merged 3 commits into from
Dec 18, 2024

Conversation

matejkubinec
Copy link
Collaborator

@matejkubinec matejkubinec commented Nov 29, 2024 •
edited
Loading

What this PR does / why we need it:

This PR fixes following issues:

  • Adds validation for node/agent fields
  • Uses FinalForm to store the selected node (to allow to preselect and keep the values after unsuccessful submit)
  • Preselects pmm-server node (when available)
  • Fixes warnings during test execution when the NodesAgents component is inside the tree

Which issue(s) this PR fixes:

PMM-13548

FB: Percona-Lab/pmm-submodules#3786

@matejkubinec matejkubinec merged commit f75050d into v3 Dec 18, 2024
3 checks passed
@matejkubinec matejkubinec deleted the PMM-13548-add-service-node-selection-fixes branch December 18, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YashSartanpara1 YashSartanpara1 YashSartanpara1 approved these changes

@doracretu3pillar doracretu3pillar Awaiting requested review from doracretu3pillar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matejkubinec @YashSartanpara1