Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/PMCP-61633: Accordion Module #839

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feature/PMCP-61633: Accordion Module #839

wants to merge 4 commits into from

Conversation

akashdhawade2005
Copy link
Contributor

@akashdhawade2005 akashdhawade2005 commented Jan 11, 2024 •
edited
Loading

Make sure you complete these items:

  • Updated root CHANGELOG.md with summary of changes under Unpublished section
  • npm run prod in this repo outputs expected changes (excepting the issue with re-ordered partials in larva-css algorithms partials - see LRVA-1885)
  • If adding a new pattern, in the PR comment, included a screenshot and link to the static Vercel deployment
  • If changes to build scripts or the Node.js server, tested changes in pmc-spark via a pre-release
    • If changes to build tools: npm scripts prod, lint, and dev scripts run as expected
    • If changes to Larva server: Static site generates as expected in a theme (avail. on a URL {brand}.stg.larva.pmcdev.io)
Screenshot at Jan 11 18-32-07 Screenshot at Jan 11 18-32-16

@github-actions GitHub Actions
Copy link
Contributor

Deploy preview for pmc-larva ready!

✅ Preview
https://pmc-larva-j0tuzxm5g-penske-media-corp.vercel.app

Built with commit 94713cb.
This pull request is being automatically deployed with vercel-action

@akashdhawade2005 akashdhawade2005 marked this pull request as ready for review January 11, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akashdhawade2005 @akashdhawade1991