Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Client.js #2768

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

abdelazizElemary
Copy link

@abdelazizElemary abdelazizElemary commented Feb 13, 2024

This change to solve the target closed issue when using puppeteer as headless

PR Details

Description

Related Issue

Motivation and Context

How Has This Been Tested

Types of changes

  • Dependency change
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation accordingly (index.d.ts).

This change to solve the target closed issue when using puppeteer as headless
@justoverclockl
Copy link

how adding a catch will solve the issue?

@joweste
Copy link

joweste commented Feb 15, 2024

Reference

I dont know, but without a catch, a lib crash when execute that code.

@abdelazizElemary
Copy link
Author

how adding a catch will solve the issue?

Without this catch it crashes when logging out if you are using puppeteer headless. Because there isn't page to listen on it's events. So the solution is simply the try and catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants