Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue with sending vcards and enhance the code to send multi vcards from string #2150

Closed
wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 17, 2023

PR Details

sending VCards from text message no longer works, after checking I found that window.Store.VCard.parseVcard(content) is not defined, so I fixed it and added the ability to send multi vcards

Description

  1. removed old code
  2. added vcard parser to window.WWebJS.parseVCardString, thanks to https://github.com/woutervroege/node-vcardparser
  3. changed the code to read vcards and validate them, then generate the correct vcard

the code is well-documented, so you can check it step by step

Related Issue

Motivation and Context

ability to send vcards wasn't working correctly

How Has This Been Tested

I tested it on my own whatsapp, worked for both multi and single vcards

Types of changes

  • Dependency change
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation accordingly (index.d.ts).

@tofers
Copy link
Contributor

tofers commented Apr 17, 2023

#1995

It's much simpler, there is already a request for a solution

@ghost ghost closed this by deleting the head repository Apr 25, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant