Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tags variable type for ECR module #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aditya81070
Copy link

Description

Description of what this PR does. What have you added or changed, and why? If it fixes a bug or resolves a feature request, be sure to link to that issue.

Issue

In the version v=0.5.1, ECR module's tags variable didn't has any variable type defined but in the v=0.6.0, the type=object has added. This is broken with new version of terraform as it requires object type variables to have specific key:value pairs. Check the object type.
Screenshot 2021-10-13 at 11 59 08 AM

Solution

This PR changes the tags type from object to map. A map can have arbitrary key:value pairs. Check the map type

Review Checks

Please check if the PR fulfills these requirements:

Put an x in the boxes that apply, Remove any lines that do not apply

  • πŸ“ The commit message is clear and descriptive
  • πŸ” The Security Considerations section in the PR description is complete - Please do not remove this
  • βœ… Tests for the changes have been added and run successfully including the new changes
  • πŸ“„ Documentation has been added / updated (for bug fixes / features)

Dependencies

Add links to any pull requests or documentation related to this pull request.
N/A

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Yes

Security Considerations

Are there any other security or data concerns to be aware of?

Please discuss the security implications/considerations relevant to the proposed change.
This may include...

  • security-relevant design decisions
  • concerns
  • important discussions
  • implementation-specific guidance and pitfalls
  • an outline of threats and risks and how they are being addressed.

N/A

Types of change

What kind of change does this Pull Request introduce?
Put an x in the boxes that apply

  • πŸ› Bugfix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • πŸ’₯ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • πŸ›  Adding or updating configuration files, development scripts etc.
  • ♻️ Refactoring (no functional changes, no api changes)
  • 🧹 Chore (removing redunant files, fixing typos etc.)
  • πŸ“„ Documentation Update
  • ❓ Other (if none of the other choices apply)

Testing

Please include steps that the reviewer can follow in order to test the changes

  1. Use the tags module to generate the tags.
  2. Pass the module.tags.default to tags input in ECR module.
  3. The terraform init should work without above mentioned error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant