add aarch64 to systems #140
Conversation
|
Thanks for the contribution @yu-re-ka! Just to double check, I assume you've verified locally this works on Apple Silicon? |
|
Ran the following tests successfully:
Failing tests:
on aarch64-linux |
|
I think there is an issue with the test runners atm, but I verified all the tests are still passing for |
| @@ -64,8 +64,10 @@ in { | |||
| ``` | |||
| */ | |||
| flake.nixosConfigurations = { | |||
| vm = nixosSystemFor "x86_64-linux" ./vm.nix; | |||
| vm-rootless = nixosSystemFor "x86_64-linux" ./vm-rootless.nix; | |||
| vm-x86_64-linux = nixosSystemFor "x86_64-linux" ./vm.nix; | |||
There was a problem hiding this comment.
I think we should do something like x86_64-linux.vm.
There was a problem hiding this comment.
Yeah I think this is nicer, otherwise I think this is ready to merge!
There was a problem hiding this comment.
Bump for @yu-re-ka, sorry if you've already seen this. Not sure if GitHub automatically notifies for comments.
|
nix run .#vm does work out of the box
14 Jun 2024 02:51:59 Edgar Lee ***@***.***>:
…
***@***.**** commented on this pull request.
----------------------------------------
In modules/nixos/default.nix[#140 (comment)]:
> @@ -64,8 +64,10 @@ in {
```
*/
flake.nixosConfigurations = {
- vm = nixosSystemFor "x86_64-linux" ./vm.nix;
- vm-rootless = nixosSystemFor "x86_64-linux" ./vm-rootless.nix;
+ vm-x86_64-linux = nixosSystemFor "x86_64-linux" ./vm.nix;
I think we should do something like *x86_64-linux.vm*. Would prefer if *.#vm* just worked out of the box, so perhaps a shortcut like *vm = nixosSystemFor system* if there's a flake-equivalent of *builtins.system* that is pure.
—
Reply to this email directly, view it on GitHub[#140 (review)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AURNSZOD7DF53IZPXZWPKUTZHI5CZAVCNFSM6AAAAABJA7ZHHGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMJXGIZTGNJQGI].
You are receiving this because you were mentioned.
[Tracking image][https://github.com/notifications/beacon/AURNSZMTLJ2DKRMJ5DEV7IDZHI5CZA5CNFSM6AAAAABJA7ZHHGWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTT6GJVV4.gif]
|
|
Regarding aarch64, I only want to merge this once its covered by CI. Will have to see if aarch64 github action workers are available. |
This allows
nix run .#vmandnix run .#vm-rootlessto work on aarch64-linux systems such as Apple Silicon Macs