Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non-copy attribute for NSCopying types that have a mutable subclass #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix non-copy attribute for NSCopying types that have a mutable subclass #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion PGXcodeActionBrowser/Common/XCIDEHelper.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
@end

@interface IDEStructureNavigator : NSObject
@property (retain) NSArray *selectedObjects;
@property (nonatomic, copy) NSArray *selectedObjects;
@end

@interface IDENavigableItemCoordinator : NSObject
Expand Down
2 changes: 1 addition & 1 deletion PGXcodeActionBrowser/Model/Actions/XCCustomAction.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,6 @@
@property (nonatomic, strong) NSImage *icon;

@property (nonatomic, strong) id representedObject;
@property (nonatomic, strong) NSArray *searchQueryMatchRanges; // REVIEW: this elsewhere
@property (nonatomic, copy) NSArray *searchQueryMatchRanges; // REVIEW: this elsewhere

@end
2 changes: 1 addition & 1 deletion PGXcodeActionBrowser/Model/XCActionInterface.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
@property (nonatomic, strong) NSImage *icon;

@property (nonatomic, strong) id representedObject;
@property (nonatomic, strong) NSArray *searchQueryMatchRanges; // REVIEW: this elsewhere
@property (nonatomic, copy) NSArray *searchQueryMatchRanges; // REVIEW: this elsewhere

- (BOOL)executeWithContext:(id<XCIDEContext>)context;
- (BOOL)executeWithContext:(id<XCIDEContext>)context arguments:(NSArray *)arguments;
Expand Down
2 changes: 1 addition & 1 deletion PGXcodeActionBrowser/Model/XCBlockAction.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ typedef void(^XCBlockActionHandler)(id<XCIDEContext> context); // context can be
@property (nonatomic, strong) NSImage *icon;

@property (nonatomic, strong) id representedObject;
@property (nonatomic, strong) NSArray *searchQueryMatchRanges; // REVIEW: this elsewhere
@property (nonatomic, copy) NSArray *searchQueryMatchRanges; // REVIEW: this elsewhere

- (instancetype)initWithTitle:(NSString *)title
action:(XCBlockActionHandler)action;
Expand Down
8 changes: 4 additions & 4 deletions PGXcodeActionBrowser/Plugin/XCActionBarConfiguration.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@
@protocol XCActionBarConfiguration <NSObject>

// Interim representation while refactoring
@property (nonatomic, readonly) NSDictionary *shortcuts;
@property (nonatomic, copy, readonly) NSDictionary *shortcuts;

@property (nonatomic, readonly) NSArray *supportedTerminalApplications;
@property (nonatomic, copy, readonly) NSArray *supportedTerminalApplications;

////////////////////////////////////////////////////////////////////////////////
// User Alerts
Expand All @@ -31,9 +31,9 @@
////////////////////////////////////////////////////////////////////////////////
@interface XCActionBarConfiguration : NSObject <XCActionBarConfiguration>

@property (nonatomic) NSDictionary *shortcuts;
@property (nonatomic, copy) NSDictionary *shortcuts;

@property (nonatomic) NSArray *supportedTerminalApplications;
@property (nonatomic, copy) NSArray *supportedTerminalApplications;

////////////////////////////////////////////////////////////////////////////////
// User Alerts
Expand Down