Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix one click payment popup issue #126

Merged
merged 1 commit into from
Apr 11, 2024
Merged

fix one click payment popup issue #126

merged 1 commit into from
Apr 11, 2024

Conversation

jshawl
Copy link
Contributor

@jshawl jshawl commented Mar 28, 2024

This PR fixes an issue where the return buyer experience opened a pop up and prompted a buyer login. The vault=true query parameter was incorrectly added in a previous PR comment (see #99 (comment))

See Demo 馃帴
Screen.Recording.2024-03-28.at.06.59.03.mov

@jshawl jshawl marked this pull request as ready for review March 28, 2024 12:10
Copy link
Contributor

@NavinPayPal NavinPayPal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gregjopa gregjopa merged commit 633fe7e into main Apr 11, 2024
2 checks passed
@gregjopa gregjopa deleted the fix-one-click-payment branch April 11, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants