Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): appends editDepth value to radio & checkbox IDs when inside drawer #6252

Merged
merged 3 commits into from May 10, 2024

Conversation

PatrikKozak
Copy link
Contributor

Description

V2 PR

Fix: appends the editDepth value to the IDs of radio and checkbox fields so when opening up a drawer (e.g. relationship add new), the radio & checkbox fields inside the drawer will have different IDs than the ones from the original document.

Beforehand, these fields were sharing the same ids so updating one of these fields inside the drawer would not change anything in the drawer but instead update the field value from the original document.

  • I have read and understand the CONTRIBUTING.md document in this repository.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Existing test suite passes locally with my changes

@PatrikKozak PatrikKozak changed the title fix(ui): appends editDepth value to radio & checkbox IDs when inside drawer fix(ui): appends editDepth value to radio & checkbox IDs when inside drawer May 7, 2024
@PatrikKozak PatrikKozak enabled auto-merge (squash) May 10, 2024 15:25
@PatrikKozak PatrikKozak merged commit dcad500 into beta May 10, 2024
34 checks passed
@PatrikKozak PatrikKozak deleted the fix/beta/radio-checkbox-edit-depth branch May 10, 2024 15:56
JessChowdhury pushed a commit that referenced this pull request May 13, 2024
JessChowdhury pushed a commit that referenced this pull request May 14, 2024
JessChowdhury pushed a commit that referenced this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants