Switched from XMLHttpRequest to fetch with try/catch #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In my testing with large number of sample reads, using fetch() instead of XMLHttpRequest appears to be faster overall. Not sure if it's related to better use of multithreading or perhaps the sample decoding happening async, but with combinations of both the standard and my custom soundfonts, this seems faster to load all the samples. Tested on my Mac with Safari, Chrome, Firefox, as well as in mobile Safari on my iPad Pro and iPhone 14 Pro Max. |
Allows for simple fixup of bad stems on combined staves by adding stems=auto to the V: voice declaration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.