Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Absolutely don't merge this YET!
Hello Mr. Rosen,
Sorry to have been so MIA these past few months. I finally found some time to work on the switch to TS this week.
Here's the migration to typescript we had discussed. It's still in draft state, but I wanted to submit it to you asap, so you'd be able to object to anything that doesn't fly.
ts-migrate
for the migration.requires
andmodules.exports
toimports
andexports
package.json
: project's "type" has been set to "module" in order to useimports
andexports
. I don't know if this potentially breaks anything for users of the library? The output still uses es5, though.<script>
imports in thehtml
files of the tests might require an "type=module" tagThat's all I have for now, I hope you'll find this PR useful!
Cheers